[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC: FileDescriptor patch
From: |
Aaron M. Renn |
Subject: |
Re: RFC: FileDescriptor patch |
Date: |
Sat, 5 Apr 2003 15:00:55 -0600 |
User-agent: |
Mutt/1.4i |
Tom Tromey (address@hidden) wrote:
> Basically I'd like to simplify FileDescriptor in a few ways. I added
> a new convenience constructor, removed the need for some special error
> handling, changed open() flags to int constants, changed
> FileDescriptor to force nativeInit to initialize the in/out/err
> fields, and removed readOnly from RandomAccessFile (the idea being,
> the native file descriptor should enforce this constraint).
Looks good. A couple things:
o This change doesn't have int flags for the synchronous write option
from RandomAccessFile. I interpreted this as requiring the O_SYNC
flag on open. True?
o The setting of in, out, and err isn't actually in nativeInit yet (I
assume you're planning to add it)
--
Aaron M. Renn (address@hidden) http://www.urbanophile.com/arenn/