[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: image loading fixes

From: Tom Tromey
Subject: Re: Patch: image loading fixes
Date: 07 Nov 2003 13:00:33 -0700
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "Tom" == Thomas Fitzsimmons <address@hidden> writes:

Tom> This patch fixes various problems related to image loading.  It also
Tom> implements Component.imageUpdate, GtkToolkit.prepareImage and the
Tom> byte-array GtkToolkit.createImage method.

Looks good.

Tom> -    // FIXME - gcj local: GdkPixbufDecoder doesn't work.
Tom> -    // return new GtkImage (new GdkPixbufDecoder (filename), null);
Tom> -    return null;
Tom> +    return new GtkImage (new GdkPixbufDecoder (filename), null);

I don't remember why I commented out this code in libgcj, other than
what the comment says.  I assume it is ok to enable now?

Tom> +    boolean incrementalDraw = Boolean.getBoolean 
Tom> +    Long redrawRate = Long.getLong ("awt.image.redrawrate");

Should these be computed once, at class init time?
Or do we want to recompute them each time this method is called?

Also, I forget where and how we're documenting properties we
recognize.  I know this has come up before though.  These two should
at least be mentioned in the javadoc for the method.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]