[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Field position attribute handling

From: Tom Tromey
Subject: Re: [PATCH] Field position attribute handling
Date: 18 Nov 2003 15:32:45 -0700
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "Dalibor" == Dalibor Topic <address@hidden> writes:

Dalibor> -    if (! (obj instanceof FieldPosition))
Dalibor> +    if (this == obj)
Dalibor> +      return true;
Dalibor> +
Dalibor> +    if (obj != null && (obj.getClass() != this.getClass()))
Dalibor>        return false;

I think this should read:

  if (obj == null || obj.getClass() != this.getClass())
    return false;

I don't think short-circuiting the this==obj case is really worth the
effort.  But I don't really care all that much.

Dalibor> +    hash = 31 * hash + (null == field_attribute ? 0 : 

Does this line need to be wrapped?  I think it goes past column 79.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]