[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Compliance of DecimalFormatSymbols

From: Dalibor Topic
Subject: Re: [PATCH] Compliance of DecimalFormatSymbols
Date: Sat, 22 Nov 2003 00:39:22 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624

Salut Guilhem,

Guilhem Lavaux wrote:

Here is an adaptation of the former patch concerning java/text.
This one is small and concerns only java/text/DecimalFormatSymbols.
According to the official specification, if the serial version is greater
than 2, you have to read the locale field. This is what is done here.

Looks good to me beside just a small point. Could you write some mauve tests to go with it, please?


ChangeLog entry:

2003-11-21 Guilhem Lavaux <address@hidden>

  * java/text/    (locale): New field.
  (serialVersionOnStream): Upgraded to number 2
  (readObject): updated to assign locale if it wasn't by the

Lacks one entry:
(DecimalFormatSymbols (Locale)): Set locale.

Other than that, looks fine to me. I'm waiting for the ChangeLog police, though ;)

dalibor topic

reply via email to

[Prev in Thread] Current Thread [Next in Thread]