[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Two methods for NumberFormat

From: Guilhem Lavaux
Subject: Re: [PATCH] Two methods for NumberFormat
Date: Sat, 22 Nov 2003 15:38:12 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630

Mark Wielaard wrote:

Hi Guilhem,

On Fri, 2003-11-21 at 21:34, Guilhem Lavaux wrote:
I am continuing the series of patches with that one, it adds two methods to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale). They have to be implemented according to Java 1.4.

Thanks for splitting this up in small chunks.
Three small comments:
- You forgot a ChangeLog entry.

Well not completely forgotten but I was between two tasks... ;-)

- Don't forget to update the copyright year.


- The second comment says 'default locale', should be 'desired locale'.
But besides that it looks fine to me. Please check it in.
Too many copy-paste... ;-)

(I would like to see us not use a space between the method and the
bracket beginning the argument list. But this class already had that and
jalopy will hopefully catch all this in the future for us.)
I've just made a probabilistic choice according to what I've seen in some other files. It seemed to me that gcc-java files tends to have that sort of practices. If you say it's wrong it doesn't matter I'll fix this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]