[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Serialization #2 (set field methods)

From: Dalibor Topic
Subject: Re: [PATCH] Serialization #2 (set field methods)
Date: Sat, 29 Nov 2003 20:43:01 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312

Hi Guilhem,

Guilhem Lavaux wrote:

This patch adds extra checking required by JDK's behaviour. If someone tries to assign a field which has not the required type then an InvalidClassException should be thrown.

Please review it.

The patch looks good to me. If we don't have mauve tests for the exceptions, it would be nice to have them.


P.S.: Should I really write a documentation for each of the methods in this patch ? I would think they are straightforward to understand... In the other case I'll try to write something.

They are straighforward, but as the methods throw exceptions I'd prefer to see the boring java docs bits, too.

dalibor topic

reply via email to

[Prev in Thread] Current Thread [Next in Thread]