Re: [PATCH] Serialization #2 (set field methods)

[Dalibor Topic]

Hi Guilhem,

Guilhem Lavaux wrote:
> Hi,
>
> This patch adds extra checking required by JDK's behaviour. If someone 
> tries to assign a field which has not the required type then an 
> InvalidClassException should be thrown.
>
> Please review it.

The patch looks good to me. If we don't have mauve tests for the 
exceptions, it would be nice to have them.

> Cheers,
> Guilhem.
>
> P.S.: Should I really write a documentation for each of the methods in 
> this patch ? I would think they are straightforward to understand... In 
> the other case I'll try to write something.

They are straighforward, but as the methods throw exceptions I'd prefer 
to see the boring java docs bits, too.

cheers,
dalibor topic