classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Serialization #5


From: Dalibor Topic
Subject: Re: [PATCH] Serialization #5
Date: Wed, 03 Dec 2003 16:33:15 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312

Salut Guilhem,

Guilhem Lavaux wrote:
Hi,

This is the patch #5 (the last will be the #6) about serialization.
It fixes the following problems:
* getField handles transient and non persistent field,
* readClassDescriptor uses the right class loader to decode fields,
it also verifies that the available fields (and required by the input stream) are
of the required types.
* if getOffset() < 0 then readFields() should not try to read any field from
the input stream.

looks good me. I have one small nit to pick:

@@ -442,18 +443,46 @@
        String field_name = this.realInputStream.readUTF ();
        dumpElementln (field_name);
        String class_name;
- +
+       // There're many cases you can't get java.lang.Class from
+       // typename if your context class loader can't load it,
+       // then use typename to construct the field
+       // GL => No. You lose the capability to access the class loader.
+       // Type resolution must be done here. If it is an object we
+       // create the class just here if it is something else we delegate
+       // to TypeSignature.

Just rewrite the comment, don't discuss it in another. ;)

cheers,
dalibor topic





reply via email to

[Prev in Thread] Current Thread [Next in Thread]