[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Proposed coding standard updates
From: |
Tom Tromey |
Subject: |
Proposed coding standard updates |
Date: |
02 Apr 2004 14:35:19 -0700 |
I'd like to propose a couple new extensions to our Java coding
standard.
This comes from ZipEntry:
dostime = (cal.get(cal.YEAR) - 1980 & 0x7f) << 25
Here, `cal' is a local variable and YEAR is a static field in
Calendar. This is valid code, but I find it somewhat confusing; the
stuff before "." is evaluated for side effects only. I'd rather we
not use static members with a non-static qualifier, and instead write
`Calendar.YEAR'.
I'd also like to get rid of unused `import' statements.
These might just be academic for the time being, I don't know if any
current compiler except the one in Eclipse can detect these things.
Still, I'd like to update hacking.texinfo and change these constructs
when they are found.
Tom
- Proposed coding standard updates,
Tom Tromey <=