[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch: check for undeflow in nio
From: |
Michael Koch |
Subject: |
Re: Patch: check for undeflow in nio |
Date: |
Tue, 15 Jun 2004 20:04:42 +0200 |
User-agent: |
KMail/1.6.2 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Dienstag, 15. Juni 2004 19:04 schrieb Dalibor Topic:
> Dalibor Topic wrote:
> > Hi all,
> >
> > attached is a changelog and a small patch to add underlow check
> > in get method in *Impl files and fix javadocs all over.
>
> Since Michael asked me to fix all the other put/get methods in nio,
> here's an ammended patch. It fixes input error checking all over
> get/put methods in nio and the associated javadocs. OK to check in?
Looks okay, except one nitpick in the Changelog entry:
* java/nio/Buffer.java:
(checkForUnderflow, checkForOverflow, checkIndex,
checkIfReadOnly, checkArraySize) New helper methods
for error checking.
* java/nio/ByteBufferHelper.java:
(checkRemainingForRead, checkRemainingForWrite,
checkAvailableForRead, checkAvailableForWrite) Removed
no longer needed methods.
The ":" have to be AFTER the method names.
* java/nio/Buffer.java
(checkForUnderflow, checkForOverflow, checkIndex,
checkIfReadOnly, checkArraySize): New helper methods
for error checking.
* java/nio/ByteBufferHelper.java
(checkRemainingForRead, checkRemainingForWrite,
checkAvailableForRead, checkAvailableForWrite): Removed
no longer needed methods.
Sorry,
Michael
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAzzo8WSOgCCdjSDsRAjxMAJ93MaJ3ogcSON8FENbFPxNzuvvhVgCeLwHw
CroHOL7CfCTz8A7BsCNrluI=
=baFE
-----END PGP SIGNATURE-----