[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: jni.h fixes
From: |
Tom Tromey |
Subject: |
Re: jni.h fixes |
Date: |
06 Jul 2004 19:07:31 -0600 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 |
>>>>> "Guilhem" == Guilhem Lavaux <address@hidden> writes:
Guilhem> * first, it is not compilable in C++ mode. I've fixed that by
Guilhem> moving some ifdef block and adding a '}' to finish the
Guilhem> 'extern "C"' block.
Hmm, we should probably merge in the libgcj version again, there are
some minor ordering differences and whatnot here, and not for any
reason I can discern.
But this looks fine, I would say go ahead and check it in, if I come
up with a merge patch later I'll of course post it...
Guilhem> * second, I think the definition for JNI_CreateJavaVM is slightly
Guilhem> wrong. Instead of
Guilhem> JNIEXPORT jint JNICALL JNI_CreateJavaVM (JavaVM **, JNIEnv **, void *);
I agree this would be preferable, but I think the spec argues against
it.
http://java.sun.com/j2se/1.4.2/docs/guide/jni/jni-12.html#JNI_CreateJavaVM
Tom
- jni.h fixes, Guilhem Lavaux, 2004/07/06
- Re: jni.h fixes,
Tom Tromey <=