[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: TimeZone
From: |
Jeroen Frijters |
Subject: |
RE: TimeZone |
Date: |
Tue, 7 Sep 2004 09:56:44 +0200 |
Mark Wielaard wrote:
> On Mon, 2004-09-06 at 17:13, Jeroen Frijters wrote:
> > I'm not sure, but I think with the recent time zone changes
> there was a
> > bug introduced. Does the patch below make sense?
> > - if (gmtOffset < 24)
> > + if (Math.abs(gmtOffset) < 24)
>
> Eep. Yes, that is the correct fix. I introduced that (or actually I
> translated the original C++ code from libgcj that did the same wrong
> thing). Sorry.
>
> All my platform specific code actually produces hours already
> so I never hit the code path that converts from seconds.
Some time zones use a half hour offset, how are those handled?
> Please check in this fix.
Done.
Regards,
Jeroen