[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [Classpathx-javamail] Patch Review: unused local variables
|
From: |
Conrad T. Pino |
|
Subject: |
RE: [Classpathx-javamail] Patch Review: unused local variables |
|
Date: |
Thu, 29 Nov 2007 10:48:10 -0800 |
Conrad T. Pino wrote:
> > Patch goals:
> >
> > 1. Remove local variable is never read warnings, 32 in total.
> >
> > Note: IMAPFolder retains "s.getConnection()" method call
> > to preserve state change side effects, if any.
>
> Yes, there are side effects. The patch seems fine.
Committed.