Re: GNU indent for C code

[Mark Wielaard]

Hi,

On Mon, 2004-03-29 at 02:03, Etienne Gagnon wrote:
> OK, to be fair, it can make "pushing" changes upstream a little more
> difficult, if one does not want to "reindent" GNU-style the whole modified
> function sent upstream.
> 
> This begs quite a few questions:
> 1- Why is the fdlibm library source code in the Classpath repository at all?
>     Shouldn't this library simply be a "static" or even "dynamic" library
>     of Classpath?  What the strong argument here, other than: "but we would
>     have to tell users where to get it" ?
> 2- If 1- has a good motivation, why isn't there a vendor branch, to allow
>     easy extraction of any improvement to send upstream?

I looked into this because these are fair questions.
(I also added this info to the Hacker's Guide)
We provide the fdlibm source code since this library is actually used to
define of some of the mathematical algorithms should behave.

See the spec for java.lang.Math and java.lang.StrictMath:
"The Java math library is defined with respect to the version of fdlibm
dated January 4, 1995. Where fdlibm provides more than one definition
for a function (such as acos), use the "IEEE 754 core function" version
(residing in a file whose name begins with the letter e)."

For us the "upstream" for these functions is actually libgcj since they
test against a lot more platforms then we do at the moment. But they
haven't actually been applying patches to it for years. Which isn't
surprising seen the fact that the spec is so specific about a particular
version of fdlibm.

As far as I could see there isn't a real distribution (package) of
fdlibm except for the raw sources at http://www.netlib.org/fdlibm/
which is the reason we ship it together with GNU Classpath.

A vendor branch might be nice and I guess nobody ever knew how to do
that or thought it wasn't necessary when it was first imported (before
my time). But given the above I don't think it really matters.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part