commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: Small GtkComponentPeer.c fixlet for gcc-2.95


From: Mark Wielaard
Subject: FYI: Small GtkComponentPeer.c fixlet for gcc-2.95
Date: Thu, 01 Jul 2004 17:54:30 +0200

Hi,

Local variables need to be defined at the start of a function.

2004-07-01  Mark Wielaard  <address@hidden>

       * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c
       (Java_gnu_java_awt_peer_gtk_GtkComponentPeer_addExposeFilter):
       Define hid at start of function.
       (Java_gnu_java_awt_peer_gtk_GtkComponentPeer_removeExposeFilter):
       Likewise.

Don't know why our compile flags don't pick this up.
But I'll try to finish a autobuilder on this machine to warn us about
these kind of issues.
Committed.

Cheers,

Mark
Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c
===================================================================
RCS file: 
/cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c,v
retrieving revision 1.31
diff -u -r1.31 gnu_java_awt_peer_gtk_GtkComponentPeer.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c        26 Jun 
2004 16:07:03 -0000      1.31
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c        1 Jul 
2004 15:50:49 -0000
@@ -1093,6 +1093,7 @@
   GList *children;
   void *ptr = NSA_GET_PTR (env, obj);
   jobject *gref = NSA_GET_GLOBAL_REF (env, obj);
+  gulong hid;
 
   g_assert (gref);
 
@@ -1126,10 +1127,9 @@
     {
       filterobj = GTK_OBJECT(ptr);
     }
-
-  gulong hid = g_signal_handler_find(filterobj,
-                                     G_SIGNAL_MATCH_FUNC,
-                                     0, 0, NULL, *pre_event_handler, NULL);
+  hid = g_signal_handler_find(filterobj,
+                              G_SIGNAL_MATCH_FUNC,
+                              0, 0, NULL, *pre_event_handler, NULL);
   if (hid > 0)
   {
     g_signal_handler_block(filterobj, hid);
@@ -1148,6 +1148,7 @@
   GList *children;
   void *ptr = NSA_GET_PTR (env, obj);
   jobject *gref = NSA_GET_GLOBAL_REF (env, obj);
+  gulong hid;
 
   g_assert (gref);
 
@@ -1184,9 +1185,9 @@
 
   g_signal_handlers_disconnect_by_func (filterobj,
                                         *filter_expose_event_handler, *gref);
-  gulong hid = g_signal_handler_find(filterobj,
-                                     G_SIGNAL_MATCH_FUNC,
-                                     0, 0, NULL, *pre_event_handler, NULL);
+  hid = g_signal_handler_find(filterobj,
+                              G_SIGNAL_MATCH_FUNC,
+                              0, 0, NULL, *pre_event_handler, NULL);
   if (hid > 0)
   {
     g_signal_handler_unblock(filterobj, hid);

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]