[gnue] r10283 - in trunk/gnue-common: . src/datasources src/datasources/drivers/Base

[reinhard]

Author: reinhard
Date: 2011-02-02 09:10:41 -0600 (Wed, 02 Feb 2011)
New Revision: 10283

Modified:
   trunk/gnue-common/
   trunk/gnue-common/src/datasources/GDataSource.py
   trunk/gnue-common/src/datasources/drivers/Base/ResultSet.py
Log:
Update the UI only if there was an actual change on requery.



Property changes on: trunk/gnue-common
___________________________________________________________________
Name: bzr:revision-info
   - timestamp: 2011-01-28 11:56:48.592999935 +0100
committer: Reinhard Müller <address@hidden>
properties: 
        branch-nick: common

   + timestamp: 2011-02-02 15:56:53.148000002 +0100
committer: Reinhard Müller <address@hidden>
properties: 
        branch-nick: common

Name: bzr:file-ids
   - packaging/win32/gnue-runtime-environment.iss       
address@hidden:trunk%2Fgnue-common:packaging%2Fwin32%2Fgnue-runtime-environment.iss

   + src/datasources/GDataSource.py     
address@hidden:trunk%2Fgnue-common:src%2Fdatasources%2FGDataSource.py
src/datasources/drivers/Base/ResultSet.py       
address@hidden:trunk%2Fgnue-common:src%2Fdatasources%2Fdrivers%2FBase%2FResultSet.py

Name: bzr:revision-id:v4
   - 3116 address@hidden
3117 address@hidden
3118 address@hidden
3119 address@hidden
3120 address@hidden
3121 address@hidden
3122 address@hidden
3123 address@hidden
3124 address@hidden
3125 address@hidden
3126 address@hidden
3127 address@hidden
3128 address@hidden
3129 address@hidden
3130 address@hidden
3131 address@hidden
3132 address@hidden
3133 address@hidden
3134 address@hidden
3135 address@hidden
3136 address@hidden
3137 address@hidden
3138 address@hidden
3139 address@hidden
3140 address@hidden
3141 address@hidden
3142 address@hidden
3143 address@hidden
3144 address@hidden
3145 address@hidden
3146 address@hidden
3147 address@hidden
3148 address@hidden
3149 address@hidden
3150 address@hidden

   + 3116 address@hidden
3117 address@hidden
3118 address@hidden
3119 address@hidden
3120 address@hidden
3121 address@hidden
3122 address@hidden
3123 address@hidden
3124 address@hidden
3125 address@hidden
3126 address@hidden
3127 address@hidden
3128 address@hidden
3129 address@hidden
3130 address@hidden
3131 address@hidden
3132 address@hidden
3133 address@hidden
3134 address@hidden
3135 address@hidden
3136 address@hidden
3137 address@hidden
3138 address@hidden
3139 address@hidden
3140 address@hidden
3141 address@hidden
3142 address@hidden
3143 address@hidden
3144 address@hidden
3145 address@hidden
3146 address@hidden
3147 address@hidden
3148 address@hidden
3149 address@hidden
3150 address@hidden
3151 address@hidden

Name: bzr:text-parents
   - 
   + src/datasources/GDataSource.py     address@hidden
src/datasources/drivers/Base/ResultSet.py       address@hidden


Modified: trunk/gnue-common/src/datasources/GDataSource.py
===================================================================
--- trunk/gnue-common/src/datasources/GDataSource.py    2011-02-02 15:10:38 UTC 
(rev 10282)
+++ trunk/gnue-common/src/datasources/GDataSource.py    2011-02-02 15:10:41 UTC 
(rev 10283)
@@ -825,11 +825,11 @@
     if self.__master:
       self.__master.requeryAll (commit)
     else:
-      self.__currentResultSet.requery (commit)
-      # Many records can have changed through backend triggers. The UI has to
-      # follow the changes.
-      self.__eventController.dispatchEvent ('dsResultSetChanged',
-          resultSet = self.__currentResultSet)
+      if self.__currentResultSet.requery (commit):
+        # Many records can have changed through backend triggers. The UI has to
+        # follow the changes.
+        self.__eventController.dispatchEvent ('dsResultSetChanged',
+            resultSet = self.__currentResultSet)
 
 
   # ---------------------------------------------------------------------------

Modified: trunk/gnue-common/src/datasources/drivers/Base/ResultSet.py
===================================================================
--- trunk/gnue-common/src/datasources/drivers/Base/ResultSet.py 2011-02-02 
15:10:38 UTC (rev 10282)
+++ trunk/gnue-common/src/datasources/drivers/Base/ResultSet.py 2011-02-02 
15:10:41 UTC (rev 10283)
@@ -764,10 +764,13 @@
         @param commit: indicate whether a commit was run since the last L{post}
             call.
 
+        @return: True if something has changed at all, False otherwise.
+
         @raise Exception: if querying the records from the backend fails for
             any reason. The exact exception classes depend on the backend.
         """
 
+        any_change = False
         index = 0
         while index < len(self.__cached_records):
             record = self.__cached_records[index]
@@ -779,12 +782,16 @@
                 else:
                     record._requery(commit)
                     index += 1
+                any_change = True
             else:
                 index += 1
 
-        self.__sync(False)
+        if any_change:
+            self.__sync(False)
 
+        return any_change
 
+
     # -------------------------------------------------------------------------
     # Merge another ResultSet into this one
     # -------------------------------------------------------------------------