[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[hurd,commited 2/7] hurd _S_msg_add_auth: Initialize new arrays to 0
From: |
Samuel Thibault |
Subject: |
[hurd,commited 2/7] hurd _S_msg_add_auth: Initialize new arrays to 0 |
Date: |
Mon, 2 Jan 2023 11:09:33 +0100 |
If make_list fails, they would be undefined, and freeup with free
uninitialized pointers.
---
hurd/hurdauth.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/hurd/hurdauth.c b/hurd/hurdauth.c
index 9086e9484c..25cc8ee88d 100644
--- a/hurd/hurdauth.c
+++ b/hurd/hurdauth.c
@@ -101,21 +101,24 @@ _S_msg_add_auth (mach_port_t me,
__mutex_lock (&_hurd_id.lock);
_hurd_check_ids ();
-#define MAKE(genaux,uidgid) \
- make_list (&new ## genaux ## uidgid ## s, \
+#define MAKE(genaux,uidgid) ({ \
+ new ## genaux ## uidgid ## s = 0; \
+ nnew ## genaux ## uidgid ## s = 0; \
+ make_list (&new ## genaux ## uidgid ## s, \
&nnew ## genaux ## uidgid ## s, \
_hurd_id.genaux.uidgid ## s, \
_hurd_id.genaux.n ## uidgid ## s, \
genaux ## uidgid ## s, \
- n ## genaux ## uidgid ## s)
+ n ## genaux ## uidgid ## s); \
+})
err = MAKE (gen, uid);
if (!err)
- MAKE (aux, uid);
+ err = MAKE (aux, uid);
if (!err)
- MAKE (gen, gid);
+ err = MAKE (gen, gid);
if (!err)
- MAKE (aux, gid);
+ err = MAKE (aux, gid);
#undef MAKE
__mutex_unlock (&_hurd_id.lock);
--
2.39.0
- [hurd,commited 0/7] hurd: fixes, Samuel Thibault, 2023/01/02
- [hurd,commited 1/7] htl: Check error returned by __getrlimit, Samuel Thibault, 2023/01/02
- [hurd,commited 2/7] hurd _S_msg_add_auth: Initialize new arrays to 0,
Samuel Thibault <=
- [hurd, commited 4/7] htl: Drop duplicate check in __pthread_stack_alloc, Samuel Thibault, 2023/01/02
- [hurd, commited 5/7] hurd: Make dl-sysdep __sbrk check __vm_allocate call, Samuel Thibault, 2023/01/02
- [hurd,commited 6/7] hurd fcntl: Make LOCKED macro more robust, Samuel Thibault, 2023/01/02
- [hurd, commited 3/7] hurd hurdstartup: Initialize remaining fields of hurd_startup_data, Samuel Thibault, 2023/01/02
- [hurd,commited 7/7] hurd getcwd: Fix memory leak on error, Samuel Thibault, 2023/01/02