[commit-womb] gnumaint Makefile README gm gnupackages.text

[Karl Berry]

CVSROOT:        /sources/womb
Module name:    gnumaint
Changes by:     Karl Berry <karl>       08/02/17 15:07:44

Modified files:
        .              : Makefile README gm gnupackages.text 

Log message:
        more work on unanswered list

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnumaint/Makefile?cvsroot=womb&r1=1.15&r2=1.16
http://cvs.savannah.gnu.org/viewcvs/gnumaint/README?cvsroot=womb&r1=1.10&r2=1.11
http://cvs.savannah.gnu.org/viewcvs/gnumaint/gm?cvsroot=womb&r1=1.9&r2=1.10
http://cvs.savannah.gnu.org/viewcvs/gnumaint/gnupackages.text?cvsroot=womb&r1=1.3&r2=1.4

Patches:
Index: Makefile
===================================================================
RCS file: /sources/womb/gnumaint/Makefile,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -b -r1.15 -r1.16
--- Makefile    15 Feb 2008 19:06:53 -0000      1.15
+++ Makefile    17 Feb 2008 15:07:44 -0000      1.16
@@ -32,6 +32,9 @@
 #      gnumaint list packages maintainer karl $(sep)
        gnumaint list packages maintainer arenn $(sep)
 
+test-activity:
+       gm check activityfile
+       
 test-nocontact:
        gm list maintainers nophysical
 

Index: README
===================================================================
RCS file: /sources/womb/gnumaint/README,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -b -r1.10 -r1.11
--- README      15 Feb 2008 19:06:53 -0000      1.10
+++ README      17 Feb 2008 15:07:44 -0000      1.11
@@ -26,6 +26,7 @@
 address@hidden
 
 todo:
+- check for inconsistent case in maintainers package names.
 - send different msg to people in recentrel.txt.
 
 bugs from last send:

Index: gm
===================================================================
RCS file: /sources/womb/gnumaint/gm,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- gm  15 Feb 2008 19:06:53 -0000      1.9
+++ gm  17 Feb 2008 15:07:44 -0000      1.10
@@ -1,5 +1,5 @@
 #!/usr/bin/env perl
-# $Id: gm,v 1.9 2008/02/15 19:06:53 karl Exp $
+# $Id: gm,v 1.10 2008/02/17 15:07:44 karl Exp $
 # More gnumaint-related stuff, since I think better in Perl than TCL.
 # 
 # Copyright 2007, 2008 Free Software Foundation Inc.
@@ -28,15 +28,31 @@
 
 sub main
 {
-  my $cmd = "list";
+  my $cmd = $ARGV[0];
   my $arg1 = $ARGV[1];
   my $arg2 = $ARGV[2];
   
-  my $fn = "list_${arg1}_${arg2}";
+  if ($cmd =~ /^-*help$/) {
+    print <<END_USAGE;
+Usage: $0 CMD ARG...
+
+Here are the possibilities:
+list packages bymaintainer   (used to generate maintainers.bypkg)
+list packages unanswered     (packages which we've had no contact about)
+list maintainers nophysical  (maintainers without phone/address info)
+check activityfile           (verify activity-report.txt)
+
+See also the gnumaint script.
+END_USAGE
+    return 0;
+  }
+
+  my $fn = "${cmd}_${arg1}_${arg2}";
   my @lines = eval "&$fn ()";
   die "$0 failed: address@hidden" if $@;
+  # ugly message on error, but this is not for public consumption.
 
-  print map { "$_\n" } @lines;
+  print map { "$_\n" } @lines if @lines;
 
   return 0;
 }
@@ -130,6 +146,8 @@
 
 
 
+# Return list of maintainers for whom we have no phone or address.
+# 
 sub list_maintainers_nophysical
 {
   my @maints = ();
@@ -148,6 +166,59 @@
 }
 
 
+
+sub check_activityfile_
+{
+  # most of these have been decommissioned, a few renamed or merged.
+  # but it seems good to preserve the original activity info.
+  my %missing_pkg_ok = (
+    "3DKit" => 1,
+    "Emacs: erc" => 1,
+    "Emacs: gnus" => 1,
+    "GNU CAD" => 1,
+    "Hegemonie" => 1,
+    "awacs" => 1,
+    "binutils-IBM-370" => 1,
+    "cilk" => 1,
+    "dr.genius" => 1,
+    "g++" => 1,
+    "getopt" => 1,
+    "gnome-panel" => 1,
+    "gphoto" => 1,
+    "lengualibre" => 1,
+    "libstdc++" => 1,
+    "recode" => 1,
+    "webpublish" => 1,
+  );
+
+  my %pkgs = &read_maintainers ("by-package");
+  my %maints = &read_maintainers ("by-maintainer");
+  
+  my %activity = &read_activity ("by-package");
+  
+  for my $ap (sort by_lineno keys %activity) {
+    next if $ap eq "*";  # our last_sendemail placeholder
+    my ($email,$name,$time,$line) = split (/\|/, $activity{$ap});
+    
+    print "$ACTIVITY_FILE:$line: active package $ap does not exist"
+          . " ($email|$name|$time)\n"
+      unless exists $pkgs{$ap} || exists $missing_pkg_ok{$ap};
+    
+  }
+  
+  return ();
+  
+  sub by_lineno
+  {
+    my (undef,undef,undef,$aline) = split (/\|/, $activity{$a});
+    my (undef,undef,undef,$bline) = split (/\|/, $activity{$b});
+    $aline <=> $bline;
+  }
+  
+}
+
+
+
 # Read $MAINTAINERS_FILE according to $HOW, either "by-package" or
 # "by-maintainer" We return a hash.  With "by-package", the keys are
 # package names and the values are a list of maintainer hash references.
@@ -248,8 +319,10 @@
 
 
 # Return hash of $ACTIVITY_FILE according to HOW:
-# if "by-package", keys are package names and values are strings "email|time";
-# if "by-email", keys are email address and values are strings "pkg|time".
+# if "by-package", keys are pkg names and
+#   values are strings "email|name|time|lineno";
+# if "by-email", keys are email addrs and
+#   values are strings "pkg|name|time|lineno".
 # Latest entry is what counts.
 # 
 sub read_activity
@@ -259,13 +332,14 @@
   
   open (ACTIVITY_FILE) || die "open($ACTIVITY_FILE) failed: $!";
   while (<ACTIVITY_FILE>) {
+    chomp;
     my ($name,$email,$pkg,$time) = split (/\|/);
 
     # later entries will simply overwrite earlier ones; seems ok?
     if ($how eq "by-package") {
-      $ret{$pkg} = "$email|$time";
+      $ret{$pkg} = "$email|$name|$time|$.";
     } elsif ($how eq "by-email") {
-      $ret{$email} = "$pkg|$time";
+      $ret{$email} = "$pkg|$name|$time|$.";
     } else {
       die "can't read_activity($how)";
     }

Index: gnupackages.text
===================================================================
RCS file: /sources/womb/gnumaint/gnupackages.text,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- gnupackages.text    5 Feb 2008 18:21:10 -0000       1.3
+++ gnupackages.text    17 Feb 2008 15:07:44 -0000      1.4
@@ -1,4 +1,4 @@
-# $Id: gnupackages.text,v 1.3 2008/02/05 18:21:10 karl Exp $
+# $Id: gnupackages.text,v 1.4 2008/02/17 15:07:44 karl Exp $
 # This file records information on a per-package basis,
 # *not* including maintainers (that's in /gd/gnuorg/maintainers).
 # 
@@ -220,7 +220,7 @@
 # copyright.list seems clear
 
 package: freedink
-gplv3-status: in-dev-sources (gnumaint-reply 24 Aug 2007 19:47:56 +0200)
+gplv3-status: in-dev-sources-no-release (gnumaint-reply 24 Aug 2007 19:47:56 
+0200)
 
 package: fribidi
 gplv3-status: discussing-with-brett (gnumaint-reply 3 Oct 2007 11:06:24)