[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Support for musl

From: Ben Elliston
Subject: Re: Support for musl
Date: Fri, 26 Jan 2018 12:33:20 +1100
User-agent: NeoMutt/20170609 (1.8.3)

Hi Henri

On Fri, Jan 26, 2018 at 11:28:31AM +1300, Henri wrote:

> Sounds good to me.  A new patch is attached.  I had to pipe stderr
> to stdout though because musl ldd writes version info to stderr.

Here's a modified version of your patch. You shouldn't use command
substitution (`...`) but just run the commands within the if
expression. The 'then' side will be run if the expression succeeds,

    if grep root /etc/passwd ; then

I am also using command -v to test for the presence of ldd. On some
Linux system, there are no development tools installed and we want to
protect against errors in this case.

Can you please test this patch? If it's good, then I'll install it.


diff --git a/config.guess b/config.guess
index ae5ffc7..89736b6 100755
--- a/config.guess
+++ b/config.guess
@@ -150,6 +150,12 @@ Linux|GNU|GNU/*)
        eval "`$CC_FOR_BUILD -E "$dummy.c" 2>/dev/null | grep '^LIBC' | sed 's, 
+       # if ldd exists, use it to detect musl libc
+       if command -v ldd >/dev/null && \
+               ldd --version 2>&1 | grep -q ^musl; then
+           LIBC=musl
+       fi

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]