[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fwd: Re: [PATCH 1/4] Rewrite basic_machine `if` with `case`

From: John Ericson
Subject: Fwd: Re: [PATCH 1/4] Rewrite basic_machine `if` with `case`
Date: Fri, 27 Apr 2018 00:37:22 -0400

My bad, forgot to also reply to list
---------- Forwarded message ----------
From: John Ericson <address@hidden>
Date: Apr 27, 2018 12:35 AM
Subject: Re: [PATCH 1/4] Rewrite basic_machine `if` with `case`
To: Ben Elliston <address@hidden>

Indeed it didn't. Is this set good with you in that regard? Conceptually, it's 3 patches in the first change and one in the second change, which is why there are only 2 change log entries, and in the 3rd and 4th commits. Feel free to squash.

I wrote it the way I did to make the diff more readable. It took a bit to work it out what was going on before, find the refactor, and convince myself that it was backwards compatible, and breaking it up into steps like this helped me. But let me know if you rather have 2 patches (or 1!) than 4 instead.


On Apr 26, 2018 9:18 PM, Ben Elliston <> wrote:

On Sat, Apr 21, 2018 at 10:01:26PM -0400, John Ericson wrote:

> OK the last email didn't contain the [PATCH] and attatchments
> instead, which may be less convenient.

It also didn't contain ChangeLog entries ..


reply via email to

[Prev in Thread] Current Thread [Next in Thread]