[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing

From: John Ericson
Subject: Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor
Date: Mon, 13 Aug 2018 12:31:29 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

Good catch. Thank you for the tests. I fixed that, and another thing that was nagging me about sequent, so I think the next two patches pass muster fine.

That just leave the deduplicate one, and the dead code it induces. I like this two-step process of 1. bolster tests and 2. refactor. So if we can make tests to decide which of the remaining special 1-component patterns make sense as actual basic-machine rules, and which just makes sense as 1-component rules, I can then fix up the 3rd patch one final time.

Thanks again for your reviewing and testing,


On 08/13/18 00:52, Ben Elliston wrote:
On Mon, Aug 13, 2018 at 12:12:56AM -0400, John Ericson wrote:

Hmm bummer. Sorry about that. Here's them all again, with that and
another hopefully "non controversial" one moved to the front.
0001 and 0002 have been applied.

0003 fails to recognise decstation-3100, whereas it did before.


Attachment: 0001-config.sub-Move-some-erroneous-foo-to-be-1-comp-alia.patch
Description: Text document

Attachment: 0002-config.sub-sequent-Make-1-component-alias.patch
Description: Text document

Attachment: 0003-config.sub-Deduplicate-basic_machine-by-filling-in-a.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]