[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing

From: Ben Elliston
Subject: Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor
Date: Mon, 20 Aug 2018 16:54:44 +1000
User-agent: NeoMutt/20170609 (1.8.3)

On Mon, Aug 20, 2018 at 02:00:32AM -0400, John Ericson wrote:

> Yes the * is probably just a cut and paste artifact. I suppose it is
> harmless and could hint to the human what the expected behavior, but
> for simplicity I just removed it. The crx- * test I deleted from the
> first patch too. That leaves the 1st patch working properly.

Thanks. Applied.

> The 2nd patch is exactly as before. It still breaks things, but that
> is intentional, with the 3rd patch fixing the breakage and the crx
> test instead. I could have combined them, but I suspect they'll be
> easier to read separately so I kept them separate. If you want to
> apply them together that is fine with me.

I am still seeing Shellcheck problems and testsuite failures with the
2nd _and_ 3rd patches applied.  Please don't break the testsuite, even


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]