Re: [PATCH 2/6] config.guess: use intermediate variable with uname results

[Dmitry V. Levin]

On Fri, May 21, 2021 at 10:39:49PM -0500, Jacob Bachmeyer wrote:
> This will allow quoting to be significantly simplified in another
>  pass through the file.
> 
> This was done with some manual cleanup after running this Emacs Lisp:

No, please don't do it this way, let it be either a manual or an automatic
change, but not a mix of those.

>   (defun edit-all-exits ()
>     (interactive)
>     (while
>         (re-search-forward
>          "^\\([[:space:]]+\\)echo[[:space:]]+\\([^\n]+\\)\n\\1exit ;;"
>          nil t)
>       (replace-match "\\1GUESS=\\2\n\\1;;")))

Sorry, I cannot verify this, please use a sed or an awk script instead.

> * config.guess: add GUESS variable to hold results of uname analysis
> ---
>  config.guess | 973 ++++++++++++++++++++++++++-------------------------
>  1 file changed, 492 insertions(+), 481 deletions(-)
> 
> diff --git a/config.guess b/config.guess
> index 92074bd..6acddd3 100755
> --- a/config.guess
> +++ b/config.guess
> @@ -84,6 +84,11 @@ if test $# != 0; then
>    exit 1
>  fi
>  
> +# just in case it came from the environment
> +if test x${GUESS+set} != xset; then
> +    GUESS=
> +fi

This looks too complicated, wouldn't a simple GUESS= suffice?


-- 
ldv