[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] config.sub: go back to backtick substitutions

From: Jacob Bachmeyer
Subject: Re: [PATCH] config.sub: go back to backtick substitutions
Date: Fri, 02 Jul 2021 19:39:33 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090807 MultiZilla/ SeaMonkey/1.1.17 Mnenhy/

Ozkan Sezer wrote:
The attached patch replaces a handful of POSIX $(xx) with classic `xx`
in config.sub. This is in line with the recent config.guess change i.e.
commit d70c4fa934de:;a=commit;h=d70c4fa934de164178054c3a60aaa0024ed07c91


While doing this, also normalizing the quoting in the `echo FOO | sed ...` would be nice. Some cases quote the argument to echo and some do not. At runtime it probably does not matter because the substituted values will never contain whitespace, but quoting them all would make shellcheck more useful.

Also see patch 5 in the recent "v2" series for the marker line to prevent shellcheck from complaining about backticks. It must be placed before the first executable line (the timestamp variable assignment) for shellcheck to apply it to the entire script.

-- Jacob

reply via email to

[Prev in Thread] Current Thread [Next in Thread]