coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [coreutils] [PATCH] tests: work around a failure with dash 0.5.4


From: Eric Blake
Subject: Re: [coreutils] [PATCH] tests: work around a failure with dash 0.5.4
Date: Tue, 07 Sep 2010 09:18:34 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat/3.1.3-1.el6 Mnenhy/0.8.3 Thunderbird/3.1.3

On 09/07/2010 08:52 AM, Pádraig Brady wrote:
commit e248506b1f664c1602acf76e98e2cafbfe9c5fab
Author: Pádraig Brady<address@hidden>
Date:   Tue Sep 7 15:53:14 2010 +0100

     tests: work around a failure with dash 0.5.4

     * tests/misc/env: Check that the shell can support
     the operation, before filtering through `env`.

diff --git a/tests/misc/env b/tests/misc/env
index 5ea01d5..96a4eab 100755
--- a/tests/misc/env
+++ b/tests/misc/env
@@ -143,8 +143,9 @@ chmod +x c=d || framework_failure
  test "x`env c=d echo fail`" = xfail || fail=1
  test "x`env -- c=d echo fail`" = xfail || fail=1
  test "x`env ./c=d echo fail`" = xfail || fail=1
-test "x$(env sh -c '\c=d echo fail')" = xpass || fail=1
  test "x$(env sh -c 'exec "$@"' sh c=d echo fail)" = xpass || fail=1
+test "x$(sh -c '\c=d echo fail')" = xpass&&  #dash 0.5.4 fails so check first
+  { test "x$(env sh -c '\c=d echo fail')" = xpass || fail=1; }

Looks good to me. For the record, at least dash 0.5.5.1 no longer has this bug.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]