Re: coreutils-8.10 released [stable]

[Jim Meyering]

Pádraig Brady wrote:
> On 05/02/11 13:59, Jim Meyering wrote:
>> Pádraig Brady wrote:
>>> Yep, just did that, and got a couple of failures for sparse-fiemap
>>> on and ext3 and loopback ext4 file systems.
>>> On a very quick glance, I think cp is OK and that the filefrag
>>> matching is a bit brittle.
>>> Attached are filefrag outputs.
>>
>> I saw similar differences, but I think they were due to the fact that
>> the kernel had not yet forced cp's metadata update to disk when filefrag
>> does its FIEMAP ioctl
>>
>> Uncommenting the "sync" just after the "cp" in the sparse-fiemap test
>> solved the problem (for me it arose only on rawhide's btrfs) but made
>> the test take a lot more time, as mentioned in the comment.
>
> It seems that the sync is needed for ext4 loop back also, on my system.
> However for ext3, the extents between src and dst still don't match up.
> My systems uses a 4K block size and is 2.6.35.10-72.fc14.i686
> For now, I've disabled (indirectly) using ext3 for fiemap-perf and
> sparse-fiemap in the attached.
>
>> Instead of that sync, using filefrag's -s option may
>> have the same result without the unwanted overhead.
>
> That doesn't work actually which baffles me.
> I got the e2fsprogs source rpm to verify that
> FIEMAP_FLAG_SYNC was set, so I guess this is a kernel issue
> (on ext4 loop back at least).
> Though I was able to get a a working sync restricted to the file
> by using dd in the attached patch.
> Even with that, the test only takes about 10s on my old laptop, so
> I didn't bother tagging the test as EXPENSIVE.

Good to hear it.

> Subject: [PATCH] test: improve the fiemap_capable_ check
>
> * tests/cp/fiemap-2: Enable the fiemap check for files, which
> will enable the test on ext3.
> * tests/cp/fiemap-perf: Comment why we're not enabling for ext3.
> * tests/cp/sparse-fiemap: Ditto.
> * tests/fiemap-capable: A new python script to determine
> if a specified path supports fiemap.
> * tests/init.cfg (fiemap_capable_): Use the new python script.
> * tests/Makefile.am (EXTRA_DIST): Include the new python script.

Very nice.
You're welcome to push that.

I've run all tests only on F14/ext4 for now,
but did confirm that your new fiemap-capable script
does the job on Solaris 10 and 11 and on freebsd 8.1.

Do you think it's worth resorting to the FS-name-based
test when python is not available?