Re: [PATCH] maint: remove unneeded includes

[Jim Meyering]

Eric Blake wrote:

> On 06/03/2011 09:06 AM, Pádraig Brady wrote:
>> On 03/06/11 15:52, Jim Meyering wrote:
>>> Nice.  Thanks!
>>> I haven't tried it yet.  How long does it take to run?
>>> Sounds like a good candidate to be run as a syntax-check rule.
>>
>> It's awkward (relies on a llvm/clang source tree for example)
>> and currently requires human interpretation.
>> It basically takes as long as clang-analyzer does.
>> Not a candidate for automation at present.
>
> In other words, our existing sc_prohibit_XXX_without_use rules are
> faster at doing the job, once we take the time to write the rules for
> each header.
>
> Are any of the headers you cleaned up in your pass worth porting into
> gnulib's maint.mk as new sc_prohibit_XXX_without_use rules?

These three were easy:

diff --git a/top/maint.mk b/top/maint.mk
index 9f20900..c55571c 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -495,6 +495,16 @@ sc_prohibit_hash_without_use:
        re='$(_hash_fn)|$(_hash_struct)'\
          $(_sc_header_without_use)

+sc_prohibit_cloexec_without_use:
+       @h='"cloexec.h"' re='\<(set_cloexec_flag|dup_cloexec) *\(' \
+         $(_sc_header_without_use)
+
+sc_prohibit_posixver_without_use:
+       @h='"posixver.h"' re='\<posix2_version *\(' $(_sc_header_without_use)
+
+sc_prohibit_same_without_use:
+       @h='"same.h"' re='\<same_name *\(' $(_sc_header_without_use)
+
 sc_prohibit_hash_pjw_without_use:
        @h='"hash-pjw.h"' \
        re='\<hash_pjw *\(' \