[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cp/reflink support for OCFS2

From: Sunil Mushran
Subject: Re: cp/reflink support for OCFS2
Date: Mon, 22 Aug 2011 08:54:34 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110617 Thunderbird/3.1.11

On 08/21/2011 06:47 AM, Jeff liu wrote:
> Thanks for your review.
>> On 05/03/2011 03:47 PM, jeff.liu wrote:
>>> Hello All,
>>> I'd like to introduce the ocfs2 reflink support to cp(1) when it was
>>> called with
>>> "--reflink=[WHEN]".
>>> With this patch, `cp' will try OCFS2 reflink first, if it fails with
>>> EEXIST, IMHO, it definitely
>>> means the user is intended to perform reflink on OCFS2, but the
>>> destination file is already exists,
>>> so set the retval = false and return, or try Btrfs clone again.
>>> I have done some tests, includes reflink on OCFS2, reflink to an
>>> existing file, reflink files
>>> cross-filesystems, and reflink attributes only, all works fine.
>>> For the test automation, the existing reflink test are presume the
>>> tests running on either file
>>> systems with Cow support IMO, maybe we can improve them with real
>>> filesystems on loop device?
>>> Also, the old bug ticket for this topic will be closed at:
>> Thanks for doing this.
>> It's a pity we've to try different file system specific CoW methods.
>> Is there any news on the reflink system call?
> Looks there is no update recently;
> Hi Joel and Sunil,
> Would you please add some comments in this point.

Last I checked, the syscall was supposed to be called fastcopy(). Probably
with the same arguments, etc. Joel knows more.

My suggestion for: cp --fast . And force users to specify it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]