[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] test-parse-datetime.c: avoid new DST-related false positive
Re: [PATCH] test-parse-datetime.c: avoid new DST-related false positive test failure
Sun, 30 Oct 2011 18:36:21 +0100
Jim Meyering wrote:
> With last night's time switch here (from CEST to CST),
> I noticed that coreutils' "make check" would fail like this:
> test-parse-datetime.c:142: assertion failed
> Fixed with this:
> Subject: [PATCH] test-parse-datetime.c: avoid new DST-related false positive
> test failure
> * tests/test-parse-datetime.c (gmt_offset): Determine the "gmt_offset"
> based on the time/date we'll convert, not the current time.
> Otherwise, the moment we cross a DST boundary like today's in
> Europe, (CEST to CET), that offset ends up being one hour off.
> ChangeLog | 8 ++++++++
> tests/test-parse-datetime.c | 22 ++++++++++------------
That was for gnulib.
The patch below pulls the fix into coreutils.
I'll probably make a release in the next two weeks,
partly in order to forestall bug reports when more
countries switch. Besides, we're already up to three
"Bug fixes", even if they're all minor.
** Bug fixes
rm -rf DIR would fail with "Device or resource busy" on Cygwin with NWFS
and NcFsd file systems. This did not affect Unix/Linux-based kernels.
[bug introduced in coreutils-8.0, when rm began using fts]
tac no longer fails to handle two or more non-seekable inputs
[bug introduced in coreutils-5.3.0]
tail -f no longer tries to use inotify on GPFS file systems
[you might say this was introduced in coreutils-7.5, along with inotify
support, but the GPFS magic number wasn't in the usual places then.]
>From 53f48c7b0e4e574a73f5a649f938a0b537489d34 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 30 Oct 2011 12:42:55 +0100
Subject: [PATCH] tests: update gnulib to latest to avoid FP DST-related test
Otherwise, "make check" would fail after e.g., a CEST-to-CST
daylight savings transition.
gnulib | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gnulib b/gnulib
index f1a5c91..56ddf0f 160000
@@ -1 +1 @@
-Subproject commit f1a5c91522554791317dc2ee763fe8c017c7b810
+Subproject commit 56ddf0fdeb52ce76718e0594db4f567401e90a2c