Re: [PATCH 1/4] grep: don't say "write error" over and over

[Stefano Lattarini]

Hi Paul, just a quick outsider nit ...

On 02/08/2012 08:22 PM, Paul Eggert wrote:
> Thanks for reviewing that.  What a mess!
> An odd thing is that the patch *did* fix things for
> Fedora 15.  Maybe its shell is busted?  But that's a
> different matter.
> 
> I think we can address this particular problem without
> relying on a new coreutils feature, though the feature
> you mention does sound useful for other reasons.
> 
> I pushed this:
> 
> tests: work portably even if SIGPIPE is ignored
> * tests/epipe: Don't rely on "trap - PIPE"; that's not portable.
> Problem reported by Eric Blake in
> <http://lists.gnu.org/archive/html/bug-grep/2012-02/msg00017.html>.
> Also, use "ls -al" rather than "echo", in case "echo" is done by a
> buggy shell that ignores write errors.
>
I think this explanation ought to be added in a code comment as well,
rather than only in the ChangeLog entry.

> And close grep's fd 3, as a sanity check.
>
And this as well, probably.

Regards,
  Stefano