Re: dd: add 'skip_bytes' and 'count_bytes' operands

[Pádraig Brady]

On 02/10/2012 04:57 PM, Pádraig Brady wrote:
> On 02/10/2012 04:21 PM, Jérémy Compostella wrote:
>> Pádraig, others,
>>
>> First, I added the missing seek_bytes feature.
>> Second, I re-wrote the patch in order to replace the _bytes operands by the
>> corresponding input/output flags.
>> Finally, I added some tests to check the new seek_bytes flag.
>>
>> I successfully run the entire tests suite.
> 
> Excellent.
> I'll review fully later.
> 
>> * doc/coreutils.texi (New features): Detail new flags and behaviors.
> 
> s/New features/dd invocation/
> 
> I've also attached a diff of some adjustments to --amend to the texinfo.

I've updated the diff slightly to add a couple more doc tweaks,
and ensure all lines are < 80 chars.
Note `make syntax-check` would have cought that for you.

I can't see any issue with the logic.
A very nice patch all round.

I'll apply this in the morning.

cheers,
Pádraig.

dd_bytes_desc.diff
Description: Text document