[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: add missing sys/types.h for ls speed-up test
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] tests: add missing sys/types.h for ls speed-up test |
|
Date: |
Mon, 20 Feb 2012 06:51:19 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
On 02/19/2012 10:45 AM, Jim Meyering wrote:
> Jérémy Compostella wrote:
>
>>> Thank you for the report and the patch.
>>> Please tell us what type/version of compiler/system you're using.
>>> It's good to include that information, especially since ssize_t
>>> is supposed to be defined via stdio.h. Then it is clear that this
>>> change is working around a problem with non-conforming systems.
>> Here the requested information:
>> - linux kernel: Linux Apollo 3.2.0-rc7+ #75 SMP Thu Jan 5 18:14:54 CET
>> 2012 x86_64 GNU/Linux
>> - gcc (Debian 4.4.5-8) 4.4.5
>> - libc6-dev 2.11.2-10
>
> Thanks.
> I've adjusted your commit log to explain why:
>
>>From 933989eca67bd82f011595937002cc284c98772d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Compostella?= <address@hidden>
> Date: Sun, 19 Feb 2012 15:38:15 +0100
> Subject: [PATCH] tests: ls/getxattr-speedup: include <sys/types.h> for older
> headers
>
> Modern <stdio.h> provides ssize_t, but the one from Debian's
> libc6-dev 2.11.2-10 apparently does not.
> * tests/ls/getxattr-speedup: Also include <sys/types.h>.
Shouldn't we be fixing this in gnulib, rather than making every client
package (including coreutils) work around it?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature