Re: [PATCH] tests: add missing sys/types.h for ls speed-up test

[Eric Blake]

On 02/20/2012 06:53 AM, Jim Meyering wrote:

>>> Modern <stdio.h> provides ssize_t, but the one from Debian's
>>> libc6-dev 2.11.2-10 apparently does not.
>>> * tests/ls/getxattr-speedup: Also include <sys/types.h>.
>>
>> Shouldn't we be fixing this in gnulib, rather than making every client
>> package (including coreutils) work around it?
> 
> Is it even a problem in gnulib?

Ah, it's already fixed there; from lib/stdio.in.h, there is this
unconditional include:

/* Get off_t and ssize_t.  Needed on many systems, including glibc 2.8
   and eglibc 2.11.2.  */
#include <sys/types.h>

> 
> Notice that that test is unusual in that it uses $CC without the usual
> -I options and on code that does not include <config.h>.

You've convinced me, this is a patch specific to and appropriate for
just coreutils.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature