Re: "ls -l": Avoid unnecessary getxattr() overhead

[Jim Meyering]

Bernhard Voelker wrote:
> On 02/26/2012 09:41 AM, Jim Meyering wrote:
...
> I've created the attached patch to make the test pass.
...
> Subject: [PATCH] tests: compile and link shared object with GCC to make
>  LD_PRELOAD work

Thanks I tweaked the title: s/G/$/
...

...
>  # Then compile/link it:
> -$CC -fPIC -O2 -c k.c || framework_failure_ 'failed to compile with -fPIC'
> -ld -G k.o -o k.so || framework_failure_ 'failed to invoke ld -G ...'
> +$CC -shared -fPIC -O2 k.c -o k.so ||
> +  framework_failure_ 'failed to compile with -shared -fPIC'
>
>  # Create a few files:
>  seq 20 | xargs touch || framework_failure_

And adjusted the above so that the operator is at the
beginning of the line:

diff --git a/tests/ls/getxattr-speedup b/tests/ls/getxattr-speedup
index 812a03b..967f7c9 100755
--- a/tests/ls/getxattr-speedup
+++ b/tests/ls/getxattr-speedup
@@ -47,8 +47,8 @@ ssize_t lgetxattr(const char *path, const char *name, void 
*value, size_t size)
 EOF

 # Then compile/link it:
-$CC -shared -fPIC -O2 k.c -o k.so ||
-  framework_failure_ 'failed to compile with -shared -fPIC'
+$CC -shared -fPIC -O2 k.c -o k.so \
+  || framework_failure_ 'failed to compile with -shared -fPIC'

 # Create a few files:
 seq 20 | xargs touch || framework_failure_