[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] maint: prohibit an operator at end of line
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 3/3] maint: prohibit an operator at end of line |
|
Date: |
Mon, 30 Apr 2012 08:29:52 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 04/30/2012 08:25 AM, Eric Blake wrote:
> On 04/30/2012 07:08 AM, Jim Meyering wrote:
>> Here's a new syntax-check rule (patch 3/3).
>> 1 and 2 fix violations so that the new check passes.
>>
>> For now, this is only in coreutils (grep had only two violations),
>> but given the long list of violations in gnulib's lib/ directory,
>> it may not be generally appealing enough to be added to gnulib's maint.mk:
>>
>> $ git grep -lE '(. [-/+]|&&|\|\|)$' lib
>
> Is it worth adding some more operators, such as *, ^, &, and |?
>
> (. [-/+*^]|&&?|\|\|?)$
Also <<, >>, ==, !=, and for that matter, all of the op= operators:
(. [-/+*^=!<>]=?|&&?|\|\|?|<<=?|>>=?)$
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature