Re: [PATCH] stat,tail: recognize new FS types: bdevfs, inodefs, qnx6

[Pádraig Brady]

On 05/10/2012 02:54 PM, Jim Meyering wrote:
> Going through the coreutils README-release procedure,
> I ran "make -C src fs-magic-compare" on my handy Fedora rawhide VM,
> and it printed these new symbol names:
> 
> # define S_MAGIC_BDEVFS 0x62646576
> # define S_MAGIC_BINFMTFS 0x42494E4D
> # define S_MAGIC_MTD_INODE_FS 0x11307854
> # define S_MAGIC_QNX6 0x68191122
> 
> One is just a renaming, but the other three are indeed new.
> Well, they're new names, at least.
> 
> The linux kernel folks recently gave names in their magic.h to
> these previously-open-coded literal hexadecimal strings.
> 
> Seeing QNX4 and QNX6, I wondered if there were a well known magic number
> for a QNX5 file system type, but a few quick searches suggest not.
> 
>>From abb809e346f7a1d240e519337db0089dcdebc154 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Thu, 10 May 2012 15:46:08 +0200
> Subject: [PATCH] stat,tail: recognize new FS types: bdevfs, inodefs, qnx6
> 
> * src/stat.c (human_fstype) [__linux__]: Add 'case's for these local
> file system types: bdevfs (0x62646576), inodefs (0x42494E4D),
> qnx6 (0x68191122).
> Now that the kernel has a name for S_MAGIC_BINFMTFS, use
> theirs in place of our S_MAGIC_BINFMT_MISC.
> * NEWS (New features): Mention it.
> ---
>  NEWS       | 2 ++
>  src/stat.c | 8 +++++++-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/NEWS b/NEWS
> index e56f8fa..9bed8ba 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -32,6 +32,8 @@ GNU coreutils NEWS                                    -*- 
> outline -*-
> 
>    fmt now accepts the --goal=WIDTH (-g) option.
> 
> +  stat -f recognize new file system types: bdevfs, inodefs, qnx6
                      ^s

Otherwise looks good.

cheers,
Pádraig.