[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] su: remove program (util-linux is now the best source for it
From: |
Jim Meyering |
Subject: |
Re: [PATCH] su: remove program (util-linux is now the best source for it) |
Date: |
Tue, 29 May 2012 20:12:26 +0200 |
Bernhard Voelker wrote:
> On 05/29/2012 05:16 PM, Jim Meyering wrote:
>> Here's a patch to remove almost all su-related artifacts from coreutils.
>
> I had a quick look on the results of
> git ls-files | xargs grep -w su
>
> This seems to be the only one missing:
>
> diff --git a/scripts/git-hooks/commit-msg b/scripts/git-hooks/commit-msg
> index 3c1c63d..a5e4090 100755
> --- a/scripts/git-hooks/commit-msg
> +++ b/scripts/git-hooks/commit-msg
> @@ -19,7 +19,7 @@ my @valid = qw(
> mv nice nl nohup nproc od paste pathchk pinky pr printenv printf
> ptx pwd readlink realpath rm rmdir runcon seq sha1sum sha224sum sha256sum
> sha384sum sha512sum shred shuf sleep sort split stat stdbuf stty
> - su sum sync tac tail tee test timeout touch tr true truncate tsort
> + sum sync tac tail tee test timeout touch tr true truncate tsort
> tty uname unexpand uniq unlink uptime users vdir wc who whoami yes
>
> copy gnulib tests maint doc build scripts
Hi Berny,
Actually, I deliberately left that one out.
Otherwise, the commit hook would prohibit this very commit,
since its summary line starts with "su:".
Of course, now that I think about it, I can override that
test with git-commit's --no-verify option.
So I'll squash that in.
Thanks!