[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] maint: add syntax-check rule to help avoid misuse of EXI
Re: [PATCH 2/2] maint: add syntax-check rule to help avoid misuse of EXIT_FAILURE
Wed, 04 Jul 2012 08:36:42 +0200
Pádraig Brady wrote:
> On 07/03/2012 08:19 PM, Jim Meyering wrote:
>> Inspired by the EXIT_FAILURE problem Pádraig spotted
>> and that Paul just fixed, I wrote a new syntax-check rule
>> to help avoid that sort of problem. The following programs
>> must avoid most new uses of EXIT_FAILURE:
>> This new syntax-check rule caught a minor problem in
>> our helper setuidgid (not installed) and I fixed another
>> minor problem in the vicinity (dead code on error path).
>> Here are the two patches:
> Nice one.
> That check is certainly warranted.
> Both patches look fine from a quick glance.
Thanks for the review. Pushed.