[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: df: -x value vs. next argument

From: Bernhard Voelker
Subject: Re: df: -x value vs. next argument
Date: Thu, 05 Jul 2012 17:33:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120601 Thunderbird/13.0

On 07/05/2012 04:51 PM, Eric Blake wrote:
> On 07/05/2012 08:48 AM, Bernhard Voelker wrote:
>> I stumbled upon this:
>>   $ df -x -h
>> It doesn't honor the -h option because that is taken as the value
>> for the -x option. Is that intended? Should it fail/warn/...?
> Intended that -x consumes the '-h' as its argument, but perhaps could be
> improved to warn if the '-x' argument doesn't match any known file
> system types.  (But NOT fail, as the rate of new file system additions
> is shockingly high even today).

Good idea, but that'd require a bit of re-factoring: the list of
file systems we maintain is in human_fstype() in stat.c.
Well, both (stat and df) handle with file systems, so it'd be
natural to have this list in a central place.
What do you think?

Have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]