[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rename: move command from util-linux to coreutils

From: Sami Kerola
Subject: Re: rename: move command from util-linux to coreutils
Date: Tue, 17 Jul 2012 17:10:16 +0200

On Mon, Jul 9, 2012 at 3:27 PM, Jim Meyering <address@hidden> wrote:

Hi Jim,

> Thanks for the fixes.

You're welcome.

> There is too much new and untested code to include this new program
> in the upcoming release.

That is ok. Perhaps coreutils 8.19 or 8.20 is suitable release target
for this command.

> A few things should be changed regardless.
> For consistency with other GNU tools:
>   s/--test/--dry-run/

I changed the option to '-u, --dry-run' which is exact match with mktemp.

> Also, please ensure that your new code compiles
> when configure with --enable-gcc-warnings.

All errors and warnings are fixed. Thank you for mentioning the
--enable-gcc-warnings, I missed it in README.hacking.

The patch is also moved on top of upstream HEAD. As I do not expect
the patch to be either rejected or accepted any time soon I probably
will have to do the same few times more, which is not a problem other
than you will see forced pushes on my side.

The following changes since commit 2f90a1b19161d4924c251dce9cf5ff8a6d4c1d13:

  maint: move two df tests from tests/misc to tests/df (2012-07-16
02:51:41 +0100)

are available in the git repository at:

  git:// rename

   Sami Kerola

reply via email to

[Prev in Thread] Current Thread [Next in Thread]