[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFE: hash-type in sum utils

From: Pádraig Brady
Subject: Re: RFE: hash-type in sum utils
Date: Thu, 26 Jul 2012 13:47:15 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 07/26/2012 12:59 PM, Ondrej Oprala wrote:
> Ok, here is my patch proposition. I hope it's satisfactory.

Thanks for doing that!
I've attached a mainly formatting cleanup patch.

BTW be careful with strlen() in a for loop test.
That may not be optimized by the compiler,
especially when the passed string is not const or restrict.

The main logic outstanding is to escape the filename
in a BSD compat fashion.
I can have a look at that if you want, but not today.


Attachment: sum-utils_prefix-adjust.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]