Re: [PATCH 4/7] tests: avoid use of '-T' in shebang line to enable perl taint mode

[Jim Meyering]

Stefano Lattarini wrote:
> On 08/30/2012 04:21 PM, Jim Meyering wrote:
>> Stefano Lattarini wrote:
>>> * tests/rm/fail-eperm: Rename ...
>>> * tests/rm/fail-eperm.xpl: ... like this
>>> * tests/Makefile.am (TESTS): Adjust.
>>> (TEST_EXTENSIONS): New, list '.xpl'.
>>> (XPL_TEST_LOGS): New, run a perl test in tainted mode.
>>> * tests/shell-or-perl: Simplify this script: we no longer need to
>>> parse the shebang line and adjust the flags in the perl invocation
>>> accordingly.
>>> ---
>>>  tests/Makefile.am                       | 8 +++++++-
>>>  tests/rm/{fail-eperm => fail-eperm.xpl} | 0
>>>  tests/shell-or-perl                     | 9 ++-------
>>>  3 files changed, 9 insertions(+), 8 deletions(-)
>>>  rename tests/rm/{fail-eperm => fail-eperm.xpl} (100%)
>>
>> Thanks for working on all of this.
>>
>> This patch turns off -T (taint-checking) for all but one of the perl-based
>> test scripts.
>>
> Which, unless I'm mistaken, is the same behaviour we had *before* the patch.
> Or am I missing something.

Oh... I was relying on memory rather than looking at code.
You're right.  Only that one test currently uses -T.