[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: make required gettext version consistent
From: |
Jim Meyering |
Subject: |
Re: [PATCH] maint: make required gettext version consistent |
Date: |
Fri, 31 Aug 2012 12:40:42 +0200 |
Stefano Lattarini wrote:
> On 08/31/2012 12:34 PM, Jim Meyering wrote:
>> Jim Meyering wrote:
>>> Stefano Lattarini wrote:
>>>> * bootstrap.conf ($buildreq): Require gettext >= 0.18.1, consistently
>>>> with the call to AM_GNU_GETTEXT_VERSION in configure.ac.
>>>>
>>>> Signed-off-by: Stefano Lattarini <address@hidden>
>>>> ---
>>>> bootstrap.conf | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/bootstrap.conf b/bootstrap.conf
>>>> index 27b5302..535900d 100644
>>>> --- a/bootstrap.conf
>>>> +++ b/bootstrap.conf
>>>> @@ -312,7 +312,7 @@ autoconf 2.64
>>>> automake 1.11.2
>>>> autopoint -
>>>> bison -
>>>> -gettext 0.17
>>>> +gettext 0.18.1
>>>
>>> Thanks. Applied.
>>
>> I have also removed your Signed-off-by: line, again.
>>
> Yes, I'll have to re-write all the pending commits that have a
> S-o-B line before sending further patches ... If you still
> notice such a line in any new patch, feel free to just tell me
> to re-send.
>
> Sorry for the noise,
No problem. This has made me realize that the recent
scripts/git-hooks/commit-msg change that was suppose to prevent
these is not working. I thought it would make "git am FILE"
fail whenever there is a Signed-off-by: line, but it does not.