[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/22] maint: fix and simplify maintainer checks

From: Stefano Lattarini
Subject: Re: [PATCH 07/22] maint: fix and simplify maintainer checks
Date: Sat, 01 Sep 2012 12:23:30 +0200

Oh, and now that I notice ...

On 09/01/2012 01:46 AM, Stefano Lattarini wrote:
> Some of them can be simplified after the previous changes, some
> of them have been downright broken them, and need fixing.
> * src/ Adjust some comments.
> (EXTRA_DIST): Avoid SPACE-TAB sequences.
> (src/dircolors.h, src/fs.h src/fs-is-local.h): Avoid 8-SPACES
> indentation.
> (_sc_check-AUTHORS): Move ...
> * (sc_check-AUTHORS): ... here (superseding the old rule
> with the same name, that was only a recursive invocation to it).
> Adjust the paths of the invoked coreutils programs, to account
> for the fact that this rule now runs in the top-level build dir,
> not in the 'src/' subdir.  Other minor cosmetic adjustments.
> (ALL_RECURSIVE_TARGETS): Remove 'sc_option_desc_uppercase' and
> 'sc_man_file_correlation', since they no longer entails any
> recursive make invocation.
> (sc_option_desc_uppercase): Remove dependency from $(all_programs):
> it isn't actually needed.
> (check-programs-vs-x): Likewise.  Also, fix heading comments to
> truly reflect what this check does.
> (all-progs-but-lbracket): Strip the 'src/' prefix from each entry
> in the list of programs; this avoids a spurious failure in the
> 'check-programs-vs-x' recipe.
> (.PHONY): No need to list targets 'sc_man_file_correlation' and
> 'sc_option_desc_uppercase': they are automatically declared phony
> by '', being recognized as syntax checks.
> xxx
... this spurious "xxx" placeholder text should be removed.

> ---
>       | 49 ++++++++++++++++++++++++++++++++++++-------------
>  src/ | 44 +++++++-------------------------------------
>  2 files changed, 43 insertions(+), 50 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]