[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/9] Patches to avoid use of make recursion in the 'src/'
Re: [PATCH v2 0/9] Patches to avoid use of make recursion in the 'src/' subdir
Sat, 01 Sep 2012 12:33:04 +0200
Stefano Lattarini wrote:
> Or ever better, what about this patch?
> Subject: [PATCH] maint: avoid yet another spurious "make distcheck" failure
Better indeed. Thanks.
However, I prefer the one-line summary I used,
("yet another" gives no clue to what is actually involved)
maint: fix build_programs definition not to use "make -C src ..."
> * dist-check.mk (built_programs): There's no need to issue recursive
> make calls in 'src/' to define this (in fact, that works no longer
> now that 'src/Makefile.am' is gone). Simply define this to the sorted
> contents of $(bin_PROGRAMS), with the 'src/' prefix and the $(EXEEXT)
> suffix (if any) removed. Reported by Jim Meyering.
> Reported-by: Jim Meyering <address@hidden>
I'm making this additional change to your log message:
- suffix (if any) removed.
- Reported-by: Jim Meyering <address@hidden>
+ suffix (if any) removed. Reported by Jim Meyering.
Please do not list email addresses in "Reported by" log comments.
The name->email correlation belongs in the combination of THANKS.in