[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 06/17] tests: remove the unused 'root-hint' target

From: Stefano Lattarini
Subject: [PATCH 06/17] tests: remove the unused 'root-hint' target
Date: Sun, 2 Sep 2012 21:55:08 +0200

* tests/ (root-hint): Here.  The interested user can see
the reasons why some tests are skipped by looking at the messages
they display on the console; here's an excerpt:

    PASS: misc/ skipped test: must be run as root
    SKIP: misc/
    PASS: misc/
    PASS: df/ skipped test: very expensive: disabled by default
    SKIP: du/

Clear enough, and more specific and precise that a generic "some tests
might need to be run as root" message.  An if that user is interested
in making those tests run anyway, he'll just take a look to the README
files to look for info.  So there's no reason to pollute the stdout
with another "hint" that is subsumed by those messages, and that might
go unnoticed anyway.

Moreover, and possibly more importantly, that hint wasn't being
displayed anyway, even before this change!  That's because the
'root-hint' target was listed as prerequisite for the 'check-recursive'
target, which however was not a dependency of the 'check' target in
'tests/' (because that makefile contains no $(SUBDIRS)
 tests/ | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tests/ b/tests/
index 1b344f8..1e1f46b 100644
--- a/tests/
+++ b/tests/
@@ -162,16 +162,6 @@ all_root_tests =                           \
        $(MAKE) check TESTS='$(root_tests)'
-check-recursive: root-hint
-# Advertise 'check-root' target.
-.PHONY: root-hint
-       @echo '***********************************************************'
-       @echo "NOTICE: Some tests may be run only as root."
-       @echo "  See the 'Running tests as root' section in README."
-       @echo '***********************************************************'
 EXTRA_DIST += $(all_tests)
 # Do not choose a name that is a shell keyword like 'if', or a

reply via email to

[Prev in Thread] Current Thread [Next in Thread]