[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: turn on --enable-gcc-warnings when in git tree

From: Eric Blake
Subject: Re: turn on --enable-gcc-warnings when in git tree
Date: Thu, 06 Sep 2012 10:03:21 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0

On 09/06/2012 09:19 AM, Jim Meyering wrote:

>> This patch should do it (although I didn't really stress-test it, but
>> just whipped something up for the purposes of a fast reply).  If you
>> like it, I'll turn it into a formal patch before committing.
> Looks right.  Thanks!

Thanks for the review.  I tested a VPATH build, and it worked, so I'm
pushing with this commit message:

commit 1c0ad05170bd095296a6151f8a912942f487e70c
Author: Eric Blake <address@hidden>
Date:   Thu Sep 6 08:20:17 2012 -0600

    build: default to --enable-gcc-warnings for git tree

    Anyone developing on coreutils can be assumed to have a new enough
    environment, such that enabling gcc warnings by default will be
    useful.  Tarballs still default to no warnings, and the defaults
    can still be overridden with --disable-gcc-warnings.

    * (gl_gcc_warnings): Set default based on environment.
    Suggested by Bernhard Voelker.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]