[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: readlink(1) of more than one file?
From: |
Jim Meyering |
Subject: |
Re: readlink(1) of more than one file? |
Date: |
Sat, 15 Dec 2012 05:32:48 +0100 |
Pádraig Brady wrote:
...
> I'll push the attached (complete with new test and doc adjustments) soon.
...
Nice. I was going to say it looked impeccable,
but then noticed a nit at the end of the test.
Thanks!
> diff --git a/tests/readlink/multi.sh b/tests/readlink/multi.sh
...
> +readlink link1 link1 || fail=1
> +readlink link1 link2 && fail=1
> +readlink link1 link2 link1 && fail=1
> +readlink -m link1 link2 || fail=1
> +
> +printf "/1\0/1\0" > exp
> +readlink -m --zero /1 /1 > out
I think you want "|| fail=1" after each of the above lines.
> +compare exp out || fail=1
> +
> +Exit $fail
- readlink(1) of more than one file?, Aaron Davies, 2012/12/12
- Re: readlink(1) of more than one file?, Pádraig Brady, 2012/12/12
- Re: readlink(1) of more than one file?, Eric Blake, 2012/12/12
- Re: readlink(1) of more than one file?, Jim Meyering, 2012/12/12
- Re: readlink(1) of more than one file?, Pádraig Brady, 2012/12/12
- Re: readlink(1) of more than one file?, Jim Meyering, 2012/12/12
- Re: readlink(1) of more than one file?, Jim Meyering, 2012/12/13
- Re: readlink(1) of more than one file?, Pádraig Brady, 2012/12/13
- Re: readlink(1) of more than one file?, Pádraig Brady, 2012/12/14
- Re: readlink(1) of more than one file?,
Jim Meyering <=
- Re: readlink(1) of more than one file?, Bernhard Voelker, 2012/12/15
- Re: readlink(1) of more than one file?, Pádraig Brady, 2012/12/15
- Re: readlink(1) of more than one file?, Dmitry V. Levin, 2012/12/15
- Re: readlink(1) of more than one file?, Pádraig Brady, 2012/12/15
- Re: readlink(1) of more than one file?, Pádraig Brady, 2012/12/17