coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: define usage note about mandatory args centrally


From: Pádraig Brady
Subject: Re: [PATCH] maint: define usage note about mandatory args centrally
Date: Wed, 23 Jan 2013 01:07:39 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 01/23/2013 12:18 AM, Bernhard Voelker wrote:
Instead of adding the text
   "Mandatory arguments to long options are mandatory
    for short options too."
in every program, define it once in system.h - similar
to emit_size_note() and emit_blocksize_note().

During the replacement, I noticed a few programs which
did not yet emit the above text although they are candidates
for it: they have at least one long option with a mandatory
argument, and a short option for the same purpose.
I added the new function there, too.

Nice one.

I've confirmed that the man pages only differ
in the additional message in some commands.
On caveat I'd have is that you merged the
\n from the messages previous to emit_mandatory_arg_note()
into that function itself.
While logically the right thing to do,
it could introduce some churn for translators.

Though fuzzy matching will probably work here,
so +1

thanks,
Pádraig.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]