[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] df (without any params) omits the root filesystem line

From: Bernhard Voelker
Subject: Re: [PATCH] df (without any params) omits the root filesystem line
Date: Mon, 28 Jan 2013 12:00:33 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

Hi Padraig,

On 01/27/2013 08:14 PM, Pádraig Brady wrote:
> On 01/27/2013 05:51 PM, Bernhard Voelker wrote:
>> Thanks. Pushed:

> Looking at this in detail is still at the end of my TODO list.

Sorry for pushing early.

> udev is a separate file system here, which now seems not displayed?

I've also noticed that.
This is because devtmpfs is marked as dummy in ME_DUMMY_0 in
mountlist.c. It has been added in December and came into
coreutils with the latest gnulib pull:

> Also do we need to treat rootfs specially in the code now?

Hmm, as a rootfs mount entry will loose against the real "/" entry
comes later, the special handling could be removed again ... but
this would change the behavior for `df -trootfs`, as it wouldn't
be shown there. On the other side, `df -tdevtmpfs` doesn't show
anything either, i.e. for dummy file systems the user would always
have to use the -a option. And this is nothing new.

Therefore, I'm inclined to make df handle rootfs like any other
dummy FS and remove the special treatment as shown in the attachment.

Have a nice day,

Attachment: df-rm-rootfs.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]