[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] df (without any params) omits the root filesystem line

From: Bernhard Voelker
Subject: Re: [PATCH] df (without any params) omits the root filesystem line
Date: Mon, 28 Jan 2013 15:00:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

On 01/28/2013 02:52 PM, Pádraig Brady wrote:
> On 01/28/2013 01:05 PM, Pádraig Brady wrote:
>> It's a bit weird though that `df -t devtmpfs` won't show
>> a devtmpfs file system unless -a is specified.
>> Maybe -t should imply -a?
> Or may be not. It's an awkward issue that's best
> not changed for this pending release I think.

Agreed - see my other mail.

> BTW there was a "suffient" typo in the commit message.

Thanks, corrected.
I also unified the mentioning of rootfs, i.e. without quotes:

 Like any other pseudo file system, df should show rootfs only
 when the -a option is specified, i.e. specifying -trootfs alone
-is not suffient.  As the rootfs entry is now elided by the
+is not sufficient.  As the rootfs entry is now elided by the
 general deduplication in filter_mount_list (commit v8.20-103-gbb116d3),
-all other references to "rootfs" can be removed again.
+all other references to rootfs can be removed again.

 * src/df.c (show_rootfs): Remove global variable.
 (ROOTFS): Remove constant.
@@ -20,7 +20,7 @@
 about eliding mount entries: it is not the first occurrence of
 the the device which wins, but now rather the entry with the
 shortest mount point name.  Also adapt the description about
-eliding pseudo file system types like "rootfs".
+eliding pseudo file system types like rootfs.
 * NEWS (Changes in behavior): Adapt entry.

Have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]